Refactor: Consolidate handler error boilerplate (ApiError + ChannelMember extractor) #83

New issue

Closed

opened 2026-07-08 02:40:31 +00:00 by icub3d · 0 comments

icub3d commented

2026-07-08 02:40:31 +00:00

Owner

Category: Refactor / simplification — found in code review 2026-07-07.

Problem

~11 resource modules each redefine an identical struct ErrorBody, type ApiResult<T>, and helpers bad_request/not_found/forbidden/conflict/internal/storage_err (messages, channels, reactions, roles, invites, membership, threads, attachments, profiles, auth, plus permissions.rs and gateway/handler.rs). Each handler also repeats the same auth → permission → channel-existence prologue.

Fix

Introduce one crate::error::ApiError enum implementing IntoResponse with From<StorageError>, and a crate-wide pub type ApiResult<T> = Result<Json<T>, ApiError>. Handlers then use ? directly.
Add a ChannelMember { perms, channel_id, user_id } extractor (FromRequestParts) that resolves the channel, verifies existence, and computes effective_permissions once — mirroring the existing MemberUser/UserPermissions extractors.

Removes several hundred lines and makes error-shape + check-ordering consistent.

**Category: Refactor / simplification** — found in code review 2026-07-07. ## Problem ~11 resource modules each redefine an identical `struct ErrorBody`, `type ApiResult<T>`, and helpers `bad_request/not_found/forbidden/conflict/internal/storage_err` (messages, channels, reactions, roles, invites, membership, threads, attachments, profiles, auth, plus permissions.rs and gateway/handler.rs). Each handler also repeats the same auth → permission → channel-existence prologue. ## Fix - [ ] Introduce one `crate::error::ApiError` enum implementing `IntoResponse` with `From<StorageError>`, and a crate-wide `pub type ApiResult<T> = Result<Json<T>, ApiError>`. Handlers then use `?` directly. - [ ] Add a `ChannelMember { perms, channel_id, user_id }` extractor (`FromRequestParts`) that resolves the channel, verifies existence, and computes `effective_permissions` once — mirroring the existing `MemberUser`/`UserPermissions` extractors. Removes several hundred lines and makes error-shape + check-ordering consistent.

icub3d added the

area:api

status:planned

type:refactor

labels

2026-07-08 02:40:31 +00:00

icub3d referenced this issue from a commit

2026-07-09 04:12:20 +00:00

refactor(server): consolidate handler error boilerplate into crate::error

icub3d referenced this issue

2026-07-09 04:12:34 +00:00

refactor(server): consolidate handler error boilerplate into crate::error (#83) #104