icub3d/decentcom
1
0
Fork 0
Code Issues 21 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Refactor: Frontend cleanup (WS token in URL, dedupe helpers, store data loading) #91

New issue
Closed
opened 2026-07-08 02:40:35 +00:00 by icub3d · 1 comment
icub3d commented 2026-07-08 02:40:35 +00:00
Owner
Copy link

Category: Refactor / simplification + minor security (frontend) — found in code review 2026-07-07.

  • Session token is passed as a WebSocket URL query param (client/src/services/gateway.ts:50) — lands in access/proxy logs and history. Prefer a subprotocol header or a short-lived one-time ticket.
  • Dedupe copy-pasted helpers: truncatePubkey/shortPubkey (MessageItem.tsx:22, MemberList.tsx:16, Setup.tsx:10) and normalizeAddress (appStore.ts:32, serverStore.ts:83) into a shared utils/.
  • serverStore.ts connect() and revalidate() duplicate the fetch-channels/roles/members + build-roleMap block — extract loadServerData(). mergeMessages re-sorts the whole array per MESSAGE_CREATE; insert instead.
  • media.ts:15 uploadFile re-implements the !response.ok error-parse already in apiRequest — share a response-error extractor.
  • Seed phrase held in React state + copied to clipboard with no clear (KeySafety.tsx) — clear generatedIdentity on completion; consider dropping/auto-clearing clipboard copy.
**Category: Refactor / simplification + minor security (frontend)** — found in code review 2026-07-07. - [ ] Session token is passed as a WebSocket **URL query param** (`client/src/services/gateway.ts:50`) — lands in access/proxy logs and history. Prefer a subprotocol header or a short-lived one-time ticket. - [ ] Dedupe copy-pasted helpers: `truncatePubkey`/`shortPubkey` (`MessageItem.tsx:22`, `MemberList.tsx:16`, `Setup.tsx:10`) and `normalizeAddress` (`appStore.ts:32`, `serverStore.ts:83`) into a shared `utils/`. - [ ] `serverStore.ts` `connect()` and `revalidate()` duplicate the fetch-channels/roles/members + build-`roleMap` block — extract `loadServerData()`. `mergeMessages` re-sorts the whole array per `MESSAGE_CREATE`; insert instead. - [ ] `media.ts:15` `uploadFile` re-implements the `!response.ok` error-parse already in `apiRequest` — share a response-error extractor. - [ ] Seed phrase held in React state + copied to clipboard with no clear (`KeySafety.tsx`) — clear `generatedIdentity` on completion; consider dropping/auto-clearing clipboard copy.
icub3d commented 2026-07-11 03:27:17 +00:00
Author
Owner
Copy link

Landed on main via #107 (commits e305ed3 + b809ffc): WS token moved out of the URL (bearer header / access_token subprotocol), deduped pubkey/address helpers, loadServerData() extraction, shared extractErrorMessage(), seed-state and clipboard clearing.

Landed on main via #107 (commits e305ed3 + b809ffc): WS token moved out of the URL (bearer header / access_token subprotocol), deduped pubkey/address helpers, loadServerData() extraction, shared extractErrorMessage(), seed-state and clipboard clearing.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/idempotent-member-role
No results found.
Labels
Clear labels   
area:api
Backend endpoints, REST, DB, Gateway

  
area:core
Shared Rust logic, crypto, Tauri shell

  
area:docs
Documentation, OpenAPI specs, architecture

  
area:infra
Deployment, Docker, build tools

  
area:ux
Frontend UI, React components, Tailwind

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
rust
Pull requests that update rust code

  
status:complete
Feature fully implemented

  
status:partial
Partially implemented (server done, client pending)

  
status:planned
Not yet started

  
type:bug
Bug fixes

  
type:design
Architectural changes, major design decisions

  
type:feature
New features

  
type:infra
Infrastructure and CI/CD changes

  
type:refactor
Code improvements without behavioral changes

  
type:refactor
Code improvements without behavioral changes

  
type:research
Spikes, investigating new tech

  
type:ux
User experience improvements

  
wontfix
This will not be worked on

No labels
area:api
area:core
area:docs
area:infra
area:ux
dependencies
documentation
duplicate
good first issue
help wanted
invalid
question
rust
status:complete
status:partial
status:planned
type:bug
type:design
type:feature
type:infra
type:refactor
type:refactor
type:research
type:ux
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
icub3d/decentcom#91
No description provided.