Refactor: Build/infra cleanup (Dockerfile sed, workspace deps, audit.toml, CI fmt) #92

New issue

Closed

opened 2026-07-08 02:40:35 +00:00 by icub3d · 0 comments

icub3d commented

2026-07-08 02:40:35 +00:00

Owner

Category: Refactor / infra — found in code review 2026-07-07.

Dockerfile sed -i '/"client\/src-tauri"/d' Cargo.toml (Dockerfile:12) is fragile — silently no-ops if formatting changes. Use a Docker-specific workspace file / exclude instead. Verify .dockerignore excludes client/, site/, target/, .git/.
Hoist repeated third-party deps into [workspace.dependencies] and use { workspace = true }: reqwest (duplicated in sdk/rust + auditbot), plus bip39, toml, url, tokio-tungstenite, anyhow, wiremock.
Slim tokio features for the SDK/bots (they don't need full).
Move the cargo audit inline --ignore RUSTSEC-... chain (.forgejo/workflows/security.yml:41) into .cargo/audit.toml with a per-entry rationale.
Release build does amd64+arm64 via QEMU (release.yml) — slow; use a native arm64 runner / cross-compile, or drop arm64 if unneeded.
Add cargo fmt --check to CI.

**Category: Refactor / infra** — found in code review 2026-07-07. - [ ] Dockerfile `sed -i '/"client\/src-tauri"/d' Cargo.toml` (`Dockerfile:12`) is fragile — silently no-ops if formatting changes. Use a Docker-specific workspace file / exclude instead. Verify `.dockerignore` excludes `client/`, `site/`, `target/`, `.git/`. - [ ] Hoist repeated third-party deps into `[workspace.dependencies]` and use `{ workspace = true }`: `reqwest` (duplicated in `sdk/rust` + `auditbot`), plus `bip39`, `toml`, `url`, `tokio-tungstenite`, `anyhow`, `wiremock`. - [ ] Slim `tokio` features for the SDK/bots (they don't need `full`). - [ ] Move the `cargo audit` inline `--ignore RUSTSEC-...` chain (`.forgejo/workflows/security.yml:41`) into `.cargo/audit.toml` with a per-entry rationale. - [ ] Release build does amd64+arm64 via QEMU (`release.yml`) — slow; use a native arm64 runner / cross-compile, or drop arm64 if unneeded. - [ ] Add `cargo fmt --check` to CI.

icub3d added the

area:infra

status:planned

type:refactor

labels

2026-07-08 02:40:35 +00:00

icub3d referenced this issue from a commit

2026-07-10 02:08:55 +00:00

refactor(infra): workspace deps, slim tokio, audit.toml, robust Dockerfile, CI fmt (#92)

icub3d referenced this issue from a commit

2026-07-10 02:08:55 +00:00

style: cargo fmt --all across the workspace