fix(roles): make member-role assignment idempotent #102

Merged

icub3d merged 1 commit from fix/idempotent-member-role into main

2026-07-09 03:52:22 +00:00

icub3d commented

2026-07-09 03:48:58 +00:00

Owner

Summary

The SDK seed run failed with:

assigning role restricted to charlie
API error (409): UNIQUE constraint failed: member_roles.user_id, member_roles.role_id

add_member_role did a plain INSERT, so granting a role a member already holds raised a UNIQUE-constraint conflict (mapped to a 409). Re-running the seed (or any repeated grant) blew up instead of being a no-op.

Fix

INSERT ... ON CONFLICT(user_id, role_id) DO NOTHING — assigning a held role is now an idempotent success (the desired end state already holds), matching the existing add_thread_follower behavior.

Test

add_member_role_is_idempotent: double-assign succeeds and does not duplicate the membership. Full server suite (129) + clippy -D warnings green.

## Summary The SDK seed run failed with: ``` assigning role restricted to charlie API error (409): UNIQUE constraint failed: member_roles.user_id, member_roles.role_id ``` `add_member_role` did a plain `INSERT`, so granting a role a member already holds raised a UNIQUE-constraint conflict (mapped to a 409). Re-running the seed (or any repeated grant) blew up instead of being a no-op. ## Fix `INSERT ... ON CONFLICT(user_id, role_id) DO NOTHING` — assigning a held role is now an idempotent success (the desired end state already holds), matching the existing `add_thread_follower` behavior. ## Test `add_member_role_is_idempotent`: double-assign succeeds and does not duplicate the membership. Full server suite (129) + `clippy -D warnings` green.

icub3d added 1 commit

2026-07-09 03:48:59 +00:00

fix(roles): make member-role assignment idempotent

Security Audit / Gitleaks (Secrets) (pull_request) Successful in 7s

Details

Security Audit / PNPM Audit (JS SCA) (pull_request) Failing after 13s

Details

Security Audit / Trivy (SCA & IaC) (pull_request) Failing after 16s

Details

CI / Client — test & lint (pull_request) Successful in 44s

Details

Security Audit / Semgrep (SAST) (pull_request) Failing after 1m3s

Details

CI / Server — test & lint (pull_request) Successful in 2m52s

Details

Security Audit / Cargo Audit (Rust SCA) (pull_request) Failing after 4m8s

Details

e62bb571e2

Assigning a role a member already holds raised a UNIQUE-constraint error
mapped to a 409, which broke re-runnable seeding:

    assigning role restricted to charlie
    API error (409): UNIQUE constraint failed: member_roles.user_id, member_roles.role_id

Use `INSERT ... ON CONFLICT(user_id, role_id) DO NOTHING` so a repeated grant
is a no-op success (the desired end state already holds), matching the existing
`add_thread_follower` pattern. Adds a storage regression test asserting a
double-assign succeeds without duplicating the membership.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

icub3d added the

area:core

type:bug

labels

2026-07-09 03:49:05 +00:00

icub3d merged commit 8817d99dbd into main

2026-07-09 03:52:22 +00:00

icub3d referenced this pull request from a commit

2026-07-09 03:52:23 +00:00

Merge pull request 'fix(roles): make member-role assignment idempotent' (#102) from fix/idempotent-member-role into main