perf(messages): batch list enrichment to fix N+1 queries #99

Merged

icub3d merged 2 commits from feature/84-batch-message-enrichment into main

2026-07-09 02:55:01 +00:00

icub3d commented

2026-07-08 03:56:46 +00:00

Owner

Summary

Fixes #84. list_messages enriched each message with three separate queries (attachments, reaction counts, thread summary) in a sequential loop — a 50-message page issued ~150 round-trips.

Fix

New batch storage methods list_attachments_for_messages(&[id]) and list_reaction_counts_for_messages(&[id], viewer) using IN (...) queries (mirroring the existing list_thread_summaries).
list_thread_summaries now returns (parent_message_id, ThreadSummary) so results can be grouped (previously it dropped the parent id, which is why the list path couldn't use it).
New enrich_messages helper: 3 batch queries total, assembled per-message in memory with HashMaps, preserving input order. list_messages uses it. Single-message paths (create/get/update) keep the simple enrich_message.

Net: 3 queries per page instead of 3 × N.

Tests

list_batches_reactions_to_correct_messages: a reaction on one of two messages appears only on that message after listing.
Updated thread_summaries_enrichment for the new tuple return.

Full server suite green (116 tests); clippy -D warnings clean.

Closes #84

## Summary Fixes #84. `list_messages` enriched each message with three separate queries (attachments, reaction counts, thread summary) in a sequential loop — a 50-message page issued ~150 round-trips. ## Fix - New batch storage methods `list_attachments_for_messages(&[id])` and `list_reaction_counts_for_messages(&[id], viewer)` using `IN (...)` queries (mirroring the existing `list_thread_summaries`). - `list_thread_summaries` now returns `(parent_message_id, ThreadSummary)` so results can be grouped (previously it dropped the parent id, which is why the list path couldn't use it). - New `enrich_messages` helper: 3 batch queries total, assembled per-message in memory with `HashMap`s, preserving input order. `list_messages` uses it. Single-message paths (create/get/update) keep the simple `enrich_message`. Net: **3 queries per page** instead of **3 × N**. ## Tests - `list_batches_reactions_to_correct_messages`: a reaction on one of two messages appears only on that message after listing. - Updated `thread_summaries_enrichment` for the new tuple return. Full server suite green (116 tests); `clippy -D warnings` clean. Closes #84

icub3d added 1 commit

2026-07-08 03:56:46 +00:00

perf(messages): batch list enrichment to fix N+1 queries

Security Audit / Gitleaks (Secrets) (pull_request) Successful in 5s

Details

Security Audit / Trivy (SCA & IaC) (pull_request) Failing after 19s

Details

Security Audit / PNPM Audit (JS SCA) (pull_request) Failing after 36s

Details

Security Audit / Semgrep (SAST) (pull_request) Failing after 1m21s

Details

CI / Client — test & lint (pull_request) Successful in 1m37s

Details

Security Audit / Cargo Audit (Rust SCA) (pull_request) Failing after 3m42s

Details

CI / Server — test & lint (pull_request) Successful in 5m22s

Details

2e3ea815f0

Listing messages ran three queries per message (attachments, reaction
counts, thread summary) in a sequential loop, so a 50-message page issued
~150 round-trips.

Add batch storage methods list_attachments_for_messages and
list_reaction_counts_for_messages (IN (...) queries), and change
list_thread_summaries to return (parent_message_id, summary) so results can
be grouped. A new enrich_messages helper fetches all three in one query
each and assembles per-message in memory, preserving order. list_messages
now issues 3 queries total instead of 3*N. Single-message paths keep using
enrich_message.

Test: a listed page groups a reaction onto the correct message and leaves
the other message's reactions empty.

Closes #84

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

icub3d added the

area:api

type:refactor

labels

2026-07-08 03:56:47 +00:00

icub3d added 1 commit

2026-07-09 02:54:35 +00:00

Merge branch 'main' into feature/84-batch-message-enrichment

Security Audit / PNPM Audit (JS SCA) (pull_request) Failing after 18s

Details

Security Audit / Gitleaks (Secrets) (pull_request) Successful in 10s

Details